Suppress Hack arr notices in thrift binary deserialization
commit132457932cfee5f1eb1f7468c9045f4fe2516b07
authorJoseph Griego <jgriego@fb.com>
Tue, 11 Sep 2018 14:43:49 +0000 (11 07:43 -0700)
committerHhvm Bot <hhvm-bot@users.noreply.github.com>
Tue, 11 Sep 2018 14:57:48 +0000 (11 07:57 -0700)
tree933e45163968a29a17918d43e0434fbbd61cad6a
parent91d35445d9b13cd33f54e782c3757d334828cc4c
Suppress Hack arr notices in thrift binary deserialization

Summary:
binary_serialize constructs a PHP array temporarily when it serializes
a thrift map--for Hack `Map`s with intish keys, this raises a notice

Reviewed By: ricklavoie

Differential Revision: D9759729

fbshipit-source-id: f289f5870930b34349f2f60332453bb6df4a0df0
hphp/runtime/ext/thrift/binary.cpp
hphp/test/slow/hack_arr_compat/thrift_map.php [new file with mode: 0644]
hphp/test/slow/hack_arr_compat/thrift_map.php.expect [new file with mode: 0644]
hphp/test/slow/hack_arr_compat/thrift_map.php.hphp_opts [new file with mode: 0644]
hphp/test/slow/hack_arr_compat/thrift_map.php.opts [new file with mode: 0644]