| commit | 124fe661a51fe8ee318f0ca9a75990e54090d84a | |
| author | qixin <xqi@facebook.com> | |
| Sat, 23 Oct 2010 19:28:39 +0000 (23 12:28 -0700) | ||
| committer | macvicar <macvicar@facebook.com> | |
| Thu, 28 Oct 2010 20:01:14 +0000 (28 13:01 -0700) | ||
| tree | 7f451a62b801d5fd32560712fdc8f63d9fb752d8 | treesnapshot (tar.gz zip) |
| parent | 4c211d4716df4b2020262e6db8fa389184241faf | commitdiff |
[Perf] Optimize injection
Summary:
(1) Inlines the ProfilerInjection m_info->m_profiler check, since hotprofiler
is only enabled at a very low rate.
(2) Use String pointer and ObjectData * for late static binding in
FrameInjection, to reduce the cost of destruction.
(3) Simplifies recursion and timeout checks. They don't really need an object
on stack to do any cleanup.
Test Plan:
fast_tests
slow_tests
production tests
DiffCamp Revision: 173643
Reviewed By: mwilliams
Commenters: ps
CC: ps, qixin, mwilliams, hphp-diffs@lists
Tasks:
#417275: Optimize FrameInjection-related code
Revert Plan:
OK
Summary:
(1) Inlines the ProfilerInjection m_info->m_profiler check, since hotprofiler
is only enabled at a very low rate.
(2) Use String pointer and ObjectData * for late static binding in
FrameInjection, to reduce the cost of destruction.
(3) Simplifies recursion and timeout checks. They don't really need an object
on stack to do any cleanup.
Test Plan:
fast_tests
slow_tests
production tests
DiffCamp Revision: 173643
Reviewed By: mwilliams
Commenters: ps
CC: ps, qixin, mwilliams, hphp-diffs@lists
Tasks:
#417275: Optimize FrameInjection-related code
Revert Plan:
OK
15 files changed: