| commit | 124c811ee27f86fc4e647e30659c40bae693a59e | |
| author | Oguz Ulgen <oulgen@fb.com> | |
| Tue, 7 Dec 2021 23:36:05 +0000 (7 15:36 -0800) | ||
| committer | Facebook GitHub Bot <facebook-github-bot@users.noreply.github.com> | |
| Tue, 7 Dec 2021 23:37:40 +0000 (7 15:37 -0800) | ||
| tree | b0ba5fdab851085538727149165cb72bf5837cc1 | treesnapshot (tar.gz zip) |
| parent | e1db70e486e0c17cf59a4700c2b62de72be883b1 | commitdiff |
Mark empty constructors as pure in tests
Summary:
Looking at coeffect violations in tests, most of them are due to constructors being defaults when they can be pure. Lets mark empty ctors to be pure.
```
fastmod '__construct\((.*?)\) \{\}' '__construct(${1})[] {}' -- hphp/test/slow/
```
Reviewed By: rodmk
Differential Revision: D32925768
fbshipit-source-id: c6f6e8136be361426c4f701235b2e6c2fb2f4494
Summary:
Looking at coeffect violations in tests, most of them are due to constructors being defaults when they can be pure. Lets mark empty ctors to be pure.
```
fastmod '__construct\((.*?)\) \{\}' '__construct(${1})[] {}' -- hphp/test/slow/
```
Reviewed By: rodmk
Differential Revision: D32925768
fbshipit-source-id: c6f6e8136be361426c4f701235b2e6c2fb2f4494
143 files changed: