| commit | 123777e683e456e41cf46699e69f02ab287ec709 | |
| author | Scott MacVicar <macvicar@fb.com> | |
| Thu, 13 Feb 2014 17:55:06 +0000 (13 09:55 -0800) | ||
| committer | Sara Golemon <sgolemon@fb.com> | |
| Tue, 18 Feb 2014 19:22:51 +0000 (18 11:22 -0800) | ||
| tree | 0e832fafbd214e92b894a5c870c9705fdeb3cd99 | treesnapshot (tar.gz zip) |
| parent | c0475f71c50107dfbed23d04e5845452a75aaa84 | commitdiff |
Cleanup some preg stuff before fixing limit
This fixes two bugs / nits that make changing the limits hard:
* We didn't test correctly for the AtomicHashArray being full.
* Inline / kill a function that would pull the regular expression directly.
This also makes the functions return false on full cache rather than
error out.
Reviewed By: @ptarjan
Differential Revision: D1173718
This fixes two bugs / nits that make changing the limits hard:
* We didn't test correctly for the AtomicHashArray being full.
* Inline / kill a function that would pull the regular expression directly.
This also makes the functions return false on full cache rather than
error out.
Reviewed By: @ptarjan
Differential Revision: D1173718
| hphp/runtime/base/preg.cpp | diffblobblamehistory | |
| hphp/test/slow/ext_preg/preg_cache_full.php | [new file with mode: 0644] | blob |
| hphp/test/slow/ext_preg/preg_cache_full.php.expectf | [new file with mode: 0644] | blob |