Remove special treatment of equality where constraints involving type accesses
commit10d2829a0bc801e71e40057667acfec71f986ec9
authorSasha Manzyuk <manzyuk@fb.com>
Wed, 2 Oct 2019 17:28:57 +0000 (2 10:28 -0700)
committerFacebook Github Bot <facebook-github-bot@users.noreply.github.com>
Wed, 2 Oct 2019 17:30:45 +0000 (2 10:30 -0700)
treec27adcd5b7817357483f7595e84ffcafcef6e8c9
parentb12325579112d30e7e413778d1512a36d016e091
Remove special treatment of equality where constraints involving type accesses

Summary: The comment above `Typing_generic_constraint.handle_eq_tconst_constraint` mentions some mysterious unresolved types that can grow as a reason why this function exists.  Does it still have to now that we have constraint-based type inference?

Reviewed By: andrewjkennedy

Differential Revision: D17550152

fbshipit-source-id: f8b5b980f377058d18f1cafc68452fb91667cd17
hphp/hack/src/typing/typing_generic_constraint.ml
hphp/hack/src/typing/typing_phase.ml
hphp/hack/test/typecheck/constraints/generic_self_type_access_failure.php.exp