Remove Tarray from the typechecker
commit10ad142d1d67ac0e36b29507664194c0685e20ae
authorVassil Mladenov <vmladenov@fb.com>
Sat, 23 Jan 2021 02:35:55 +0000 (22 18:35 -0800)
committerFacebook GitHub Bot <facebook-github-bot@users.noreply.github.com>
Sat, 23 Jan 2021 02:38:46 +0000 (22 18:38 -0800)
tree7e49d67fea648d4df29db1a18f6c7d6498d73b5d
parent115a5a09932e1215518fd1d6a8f943d2fb80a011
Remove Tarray from the typechecker

Summary: This removes the `Tarray` type that previously represented `array`, `array<Tv>`, and `array<Tk, Tv>`. Further, special casing of `array_map` is removed in this diff.

Reviewed By: Wilfred

Differential Revision: D24370672

fbshipit-source-id: 39df94a421447c25fc08deb518153bdd5486ba72
60 files changed:
hphp/hack/src/decl/decl_instantiate.ml
hphp/hack/src/decl/decl_pos_utils.ml
hphp/hack/src/oxidized_by_ref/decl_visitor/node_impl_gen.rs
hphp/hack/src/oxidized_by_ref/gen/typing_defs_core.rs
hphp/hack/src/oxidized_by_ref/manual/typing_defs_core_impl.rs
hphp/hack/src/typing/type_visitor.ml
hphp/hack/src/typing/typing_defs.ml
hphp/hack/src/typing/typing_defs_core.ml
hphp/hack/src/typing/typing_defs_core.mli
hphp/hack/src/typing/typing_enforceability.ml
hphp/hack/src/typing/typing_enforceable_hint.ml
hphp/hack/src/typing/typing_generic.ml
hphp/hack/src/typing/typing_kinding.ml
hphp/hack/src/typing/typing_phase.ml
hphp/hack/src/typing/typing_print.ml
hphp/hack/src/typing/typing_reified_check.ml
hphp/hack/src/typing/typing_special_fun.ml
hphp/hack/src/typing/typing_utils.ml
hphp/hack/src/typing/typing_variance.ml
hphp/hack/test/error_formatting_highlighted/array_map_explicitly_typed_error.php [deleted file]
hphp/hack/test/error_formatting_highlighted/array_map_explicitly_typed_error.php.exp [deleted file]
hphp/hack/test/tast/array_map.php.exp
hphp/hack/test/typecheck/array/safe_vector_array/darray_with_array_map_does_not_return_vect_like_array.php [deleted file]
hphp/hack/test/typecheck/array/safe_vector_array/darray_with_array_map_does_not_return_vect_like_array.php.exp [deleted file]
hphp/hack/test/typecheck/array/safe_vector_array/darray_with_array_map_returns_dict_like_array.php [deleted file]
hphp/hack/test/typecheck/array/safe_vector_array/darray_with_array_map_returns_dict_like_array.php.exp [deleted file]
hphp/hack/test/typecheck/array/safe_vector_array/darray_with_array_map_returns_dict_like_array.php.like_types.exp [deleted file]
hphp/hack/test/typecheck/array/safe_vector_array/varray_with_array_map_does_not_return_dict_like_array.php [deleted file]
hphp/hack/test/typecheck/array/safe_vector_array/varray_with_array_map_does_not_return_dict_like_array.php.exp [deleted file]
hphp/hack/test/typecheck/array_map_filter/array_map.php [deleted file]
hphp/hack/test/typecheck/array_map_filter/array_map.php.exp [deleted file]
hphp/hack/test/typecheck/array_map_filter/array_map1.php [deleted file]
hphp/hack/test/typecheck/array_map_filter/array_map1.php.exp [deleted file]
hphp/hack/test/typecheck/array_map_filter/array_map10.php [deleted file]
hphp/hack/test/typecheck/array_map_filter/array_map10.php.exp [deleted file]
hphp/hack/test/typecheck/array_map_filter/array_map2.php [deleted file]
hphp/hack/test/typecheck/array_map_filter/array_map2.php.exp [deleted file]
hphp/hack/test/typecheck/array_map_filter/array_map3.php [deleted file]
hphp/hack/test/typecheck/array_map_filter/array_map3.php.exp [deleted file]
hphp/hack/test/typecheck/array_map_filter/array_map4.php [deleted file]
hphp/hack/test/typecheck/array_map_filter/array_map4.php.exp [deleted file]
hphp/hack/test/typecheck/array_map_filter/array_map5.php [deleted file]
hphp/hack/test/typecheck/array_map_filter/array_map5.php.exp [deleted file]
hphp/hack/test/typecheck/array_map_filter/array_map7.php [deleted file]
hphp/hack/test/typecheck/array_map_filter/array_map7.php.exp [deleted file]
hphp/hack/test/typecheck/array_map_filter/array_map7.php.like_types.exp [deleted file]
hphp/hack/test/typecheck/array_map_filter/array_map9.php [deleted file]
hphp/hack/test/typecheck/array_map_filter/array_map9.php.exp [deleted file]
hphp/hack/test/typecheck/array_map_filter/array_map_explicitly_typed.php [deleted file]
hphp/hack/test/typecheck/array_map_filter/array_map_explicitly_typed.php.exp [deleted file]
hphp/hack/test/typecheck/array_map_filter/array_map_explicitly_typed_arity.php [deleted file]
hphp/hack/test/typecheck/array_map_filter/array_map_explicitly_typed_arity.php.exp [deleted file]
hphp/hack/test/typecheck/array_map_filter/array_map_explicitly_typed_error.php [deleted file]
hphp/hack/test/typecheck/array_map_filter/array_map_explicitly_typed_error.php.exp [deleted file]
hphp/hack/test/typecheck/deprecated_fun_id.php [deleted file]
hphp/hack/test/typecheck/deprecated_fun_id.php.exp [deleted file]
hphp/hack/test/typecheck/unused_awaitable16.php [deleted file]
hphp/hack/test/typecheck/unused_awaitable16.php.exp [deleted file]
hphp/hack/test/typecheck/void_usage_5.php [deleted file]
hphp/hack/test/typecheck/void_usage_5.php.exp [deleted file]