| commit | 0fe56114699e83995e82bc78f55ccef0d8ecd27f | |
| author | Dwayne Reeves <dreeves@fb.com> | |
| Fri, 13 Sep 2019 19:38:41 +0000 (13 12:38 -0700) | ||
| committer | Hhvm Bot <hhvm-bot@users.noreply.github.com> | |
| Fri, 13 Sep 2019 19:41:40 +0000 (13 12:41 -0700) | ||
| tree | 150bb105d7fba609130f5f4baf2cea998a11fb1b | treesnapshot (tar.gz zip) |
| parent | 7905d573c7d3b9e513f4aa5b0f8290123af8ed78 | commitdiff |
Change Typing_env.tparams_visitor to use locl_type_visitor
Summary:
One of the remaining users of Type_visitor.type_visitor is Typing_env.tparams_visitor. This visitor appears to operate on locl_ty, but following the chain of calls it ends up being used in code in Typing_print.full_with_identity
This function accepts either `decl_ty` or `locl_ty`. To make the function monomorphic, I localize `decl_ty` in Tast_env.print_ty_with_identity.
This has a potential of changing what is printed in serverHover.ml and serverSignatureHelp.ml, but I'm assuming test will catch this.
Reviewed By: jewelpit
Differential Revision: D17352380
fbshipit-source-id: 6b5e0d0c619036f5cde8e548f66e2cd24ec0c794
Summary:
One of the remaining users of Type_visitor.type_visitor is Typing_env.tparams_visitor. This visitor appears to operate on locl_ty, but following the chain of calls it ends up being used in code in Typing_print.full_with_identity
This function accepts either `decl_ty` or `locl_ty`. To make the function monomorphic, I localize `decl_ty` in Tast_env.print_ty_with_identity.
This has a potential of changing what is printed in serverHover.ml and serverSignatureHelp.ml, but I'm assuming test will catch this.
Reviewed By: jewelpit
Differential Revision: D17352380
fbshipit-source-id: 6b5e0d0c619036f5cde8e548f66e2cd24ec0c794