| commit | 0d26915e02a4b46b574b5f44d6a786df8e0725fa | |
| author | Andrew Kennedy <akenn@fb.com> | |
| Wed, 31 Aug 2022 00:37:10 +0000 (30 17:37 -0700) | ||
| committer | Facebook GitHub Bot <facebook-github-bot@users.noreply.github.com> | |
| Wed, 31 Aug 2022 00:37:10 +0000 (30 17:37 -0700) | ||
| tree | 79ad9d15dd52fcaf8ce38bda28a77fb112c8ca2b | treesnapshot (tar.gz zip) |
| parent | 15bc6cecb396c1eb7d5329e1dfd0d8cd71b51570 | commitdiff |
Remove redundant parameter type checks during closure checking
Summary:
When checking lambdas and anonymous functions, we perform some redundant checking of explicit type hints against the type that has been constructed for the parameter (e.g. from the expected type). It seems that this code is a hangover from when (years ago) we checked lambda definitions against their application sites.
New test for Sound Dynamic, which was rejected (wrongly) prior to this diff.
It looks like there is a bunch more cleanup we can do for lambdas and lambda parameters, which I will leave for future diffs.
Reviewed By: vassilmladenov
Differential Revision: D39130178
fbshipit-source-id: 818defcb5ea783af2b9f493057d917a008d6eedb
Summary:
When checking lambdas and anonymous functions, we perform some redundant checking of explicit type hints against the type that has been constructed for the parameter (e.g. from the expected type). It seems that this code is a hangover from when (years ago) we checked lambda definitions against their application sites.
New test for Sound Dynamic, which was rejected (wrongly) prior to this diff.
It looks like there is a bunch more cleanup we can do for lambdas and lambda parameters, which I will leave for future diffs.
Reviewed By: vassilmladenov
Differential Revision: D39130178
fbshipit-source-id: 818defcb5ea783af2b9f493057d917a008d6eedb