| commit | 0bdc3ad1603f66afdc9e3dfb4979a24e4ee295d2 | |
| author | Philip Hölzenspies <drphil@fb.com> | |
| Mon, 16 Apr 2018 14:06:05 +0000 (16 07:06 -0700) | ||
| committer | Hhvm Bot <hhvm-bot@users.noreply.github.com> | |
| Mon, 16 Apr 2018 14:08:01 +0000 (16 07:08 -0700) | ||
| tree | e5a5f48a7e25acc7693b67c68a87011343515dba | treesnapshot (tar.gz zip) |
| parent | 740551262a0873ad7bef57253439555971f0c211 | commitdiff |
Non fataling parse errors should still be raised in the lowerer
Summary:
When the full fidelity parser recovers from errors, it logs them and continues.
For parity with `Parser_hack` to comply with expected behaviour of `hh_server`,
these errors should be raised, however. The lowerer didn't do that. Now it
does.
Reviewed By: dabek
Differential Revision: D7599552
fbshipit-source-id: d5b6ed7a350157e513fbe9b4528089653fa872ff
Summary:
When the full fidelity parser recovers from errors, it logs them and continues.
For parity with `Parser_hack` to comply with expected behaviour of `hh_server`,
these errors should be raised, however. The lowerer didn't do that. Now it
does.
Reviewed By: dabek
Differential Revision: D7599552
fbshipit-source-id: d5b6ed7a350157e513fbe9b4528089653fa872ff
| hphp/hack/src/parser/full_fidelity_ast.ml | diffblobblamehistory |