| commit | 0ba3231696fb8374517b8ef141efd489d1edc340 | |
| author | Joseph Griego <jgriego@fb.com> | |
| Thu, 27 Jun 2019 20:26:14 +0000 (27 13:26 -0700) | ||
| committer | Hhvm Bot <hhvm-bot@users.noreply.github.com> | |
| Thu, 27 Jun 2019 20:39:35 +0000 (27 13:39 -0700) | ||
| tree | 432e20669b64ce08e2e8c4d4c8bfe2e95c88ff1b | treesnapshot (tar.gz zip) |
| parent | ba945a4b85dbbf6b7701563cf927e1e0a2f9f4f1 | commitdiff |
Move all id generation into transpile_context
Summary:
Having these in separate places and initialized at program launch
means that the generated units might differ nondeterminstically.
Instead, generate incrementing ids on a per-file basis by shoving the state in
Transpile_context.t
Also puts the location id generation behind a flag so we don't do it unless we actually want those IDs (which, we don't right now)
Reviewed By: JacksonGL
Differential Revision: D15994933
fbshipit-source-id: bd0d29889df491d4d21fc05d1e988187c9717486
Summary:
Having these in separate places and initialized at program launch
means that the generated units might differ nondeterminstically.
Instead, generate incrementing ids on a per-file basis by shoving the state in
Transpile_context.t
Also puts the location id generation behind a flag so we don't do it unless we actually want those IDs (which, we don't right now)
Reviewed By: JacksonGL
Differential Revision: D15994933
fbshipit-source-id: bd0d29889df491d4d21fc05d1e988187c9717486
| hphp/hack/src/hhbc/hhbc_options.ml | diffblobblamehistory | |
| hphp/runtime/base/runtime-option.h | diffblobblamehistory |