| commit | 0a803a57094b68e93042d02f86bda3a20ca8b08e | |
| author | Lucian Wischik <ljw@fb.com> | |
| Tue, 4 Apr 2017 05:44:01 +0000 (3 22:44 -0700) | ||
| committer | Hhvm Bot <hhvm-bot@users.noreply.github.com> | |
| Tue, 4 Apr 2017 05:58:47 +0000 (3 22:58 -0700) | ||
| tree | f46a5ad26b3e2ce030919ed02d62815ba4c1f60a | treesnapshot (tar.gz zip) |
| parent | 7516bf530c76964a84399d85ba22eda0ed41df6c | commitdiff |
implement textDocument/documentHighlight
Summary:
This is the LSP request for highlight symbols within document.
The code for ide_range_to_lsp is ugly. I think that's a fair reflection of the OCaml ugliness of warning 45 "this shadows the label line" and didn't try to sugar-coat it.
Ultimately I think we expect the ide_ stuff to go away, and Hack internals will stick solely with Hack datastructures, and LSP stuff map those to the LSP datastructures.
Reviewed By: dabek
Differential Revision: D4787436
fbshipit-source-id: 8e6758338b5770722b31b8058e5614e4e8e3609c
Summary:
This is the LSP request for highlight symbols within document.
The code for ide_range_to_lsp is ugly. I think that's a fair reflection of the OCaml ugliness of warning 45 "this shadows the label line" and didn't try to sugar-coat it.
Ultimately I think we expect the ide_ stuff to go away, and Hack internals will stick solely with Hack datastructures, and LSP stuff map those to the LSP datastructures.
Reviewed By: dabek
Differential Revision: D4787436
fbshipit-source-id: 8e6758338b5770722b31b8058e5614e4e8e3609c
| hphp/hack/src/client/clientLsp.ml | diffblobblamehistory | |
| hphp/hack/src/ide_rpc/lsp.ml | diffblobblamehistory | |
| hphp/hack/src/ide_rpc/lsp_fmt.ml | diffblobblamehistory |