| commit | 0a47209aaf199be002beb772f0c468477a6feea4 | |
| author | Paul Bissonnette <paulbiss@fb.com> | |
| Thu, 17 Oct 2019 06:54:13 +0000 (16 23:54 -0700) | ||
| committer | Facebook Github Bot <facebook-github-bot@users.noreply.github.com> | |
| Thu, 17 Oct 2019 06:57:09 +0000 (16 23:57 -0700) | ||
| tree | 9bc0140f92569ffc73692ddde2d6d10f9ee8ee36 | treesnapshot (tar.gz zip) |
| parent | ac5b0592bb33d7c57b728d85714f6d3f3da5263c | commitdiff |
Always require $this on instance methods
Summary:
We removed support for calling instance methods statically already so mark them as needing a `$this`. Follow up diffs to remove the attribute entirely.
It looks like we were still allowing calling instance methods statically in two places. (1) raw `invokeFunc` from the runtime, most notably for the `86*init` functions (added a verifier pass to stop this from happening and fix some tests), and (2) `call_user_func`.
Reviewed By: ottoni, jano, alexeyt
Differential Revision: D16060802
fbshipit-source-id: f8c2971908d8d92fbbf08ce8706e9f7614de5c6a
Summary:
We removed support for calling instance methods statically already so mark them as needing a `$this`. Follow up diffs to remove the attribute entirely.
It looks like we were still allowing calling instance methods statically in two places. (1) raw `invokeFunc` from the runtime, most notably for the `86*init` functions (added a verifier pass to stop this from happening and fix some tests), and (2) `call_user_func`.
Reviewed By: ottoni, jano, alexeyt
Differential Revision: D16060802
fbshipit-source-id: f8c2971908d8d92fbbf08ce8706e9f7614de5c6a
48 files changed: