| commit | 0a372db2a31877790025c81310da7612962bc681 | |
| author | Alexey Toptygin <alexeyt@fb.com> | |
| Wed, 2 Oct 2019 20:21:00 +0000 (2 13:21 -0700) | ||
| committer | Facebook Github Bot <facebook-github-bot@users.noreply.github.com> | |
| Wed, 2 Oct 2019 20:22:34 +0000 (2 13:22 -0700) | ||
| tree | f30b625ec5f8d3ba8fb71b6066371b2b11078999 | treesnapshot (tar.gz zip) |
| parent | 250a8e0ec4c0b700a7122dd9106c8b77b84836ea | commitdiff |
Revert visibility of class/type constants.
Summary:
This was partly built but abandoned as a direction we don't intend to pursue further. It also blocks me from using the presence of visibility modifiers to differentiate constant declarations from const property declarations.
Revert the stack from D16043672 to D16087542, D15981533, and D16137608 except for some useful refactors:
* refactors in hphp/hack/src/typing/typing_extends.ml from D16081937 and D16085948
* the bits of D16075262 that were plumbing type const modifiers (in general, as opposed to visibility ones specifically) into the ast
* the parts of D16069842 that changed class_const from a tuple to a struct
Reviewed By: dabek
Differential Revision: D17680976
fbshipit-source-id: 2342037619ddfaeb8ee1414e8871af5c77fb5eaa
Summary:
This was partly built but abandoned as a direction we don't intend to pursue further. It also blocks me from using the presence of visibility modifiers to differentiate constant declarations from const property declarations.
Revert the stack from D16043672 to D16087542, D15981533, and D16137608 except for some useful refactors:
* refactors in hphp/hack/src/typing/typing_extends.ml from D16081937 and D16085948
* the bits of D16075262 that were plumbing type const modifiers (in general, as opposed to visibility ones specifically) into the ast
* the parts of D16069842 that changed class_const from a tuple to a struct
Reviewed By: dabek
Differential Revision: D17680976
fbshipit-source-id: 2342037619ddfaeb8ee1414e8871af5c77fb5eaa
96 files changed: