Use interfaces for types in ET type tests
commit08960972b7475f1423c3763a9da5d36aecbae8d6
authorWilfred Hughes <wilfred@fb.com>
Fri, 1 Oct 2021 00:24:09 +0000 (30 17:24 -0700)
committerFacebook GitHub Bot <facebook-github-bot@users.noreply.github.com>
Fri, 1 Oct 2021 00:25:46 +0000 (30 17:25 -0700)
tree6232228f38ee2d67767b5df7f5103a9906497bdb
parentc3001bcb08ebf86c596a80d29b3b37635a7e9224
Use interfaces for types in ET type tests

Summary: Interfaces are arguably clearer, as they show the types without requiring us to implement anything. This is also how MinScript and EtDemo has chosen to implement its visitors.

Differential Revision: D31071937

fbshipit-source-id: acbd740d2d0d0583c7cbf2c5033dd77f84138c6a
hphp/hack/test/hhi/expr_tree.hhi
hphp/hack/test/typecheck/expression_trees/boolean_operators.php.exp
hphp/hack/test/typecheck/expression_trees/property_access_error3.php.exp
hphp/hack/test/typecheck/expression_trees/splice_err2.php.exp
hphp/hack/test/typecheck/expression_trees/splice_err3.php.exp
hphp/hack/test/typecheck/expression_trees/splice_err5.php.exp