| commit | 06315cd66263245be417a9b89b6de3a3320b4d9f | |
| author | Lucian Wischik <ljw@fb.com> | |
| Tue, 4 Aug 2020 17:25:45 +0000 (4 10:25 -0700) | ||
| committer | Facebook GitHub Bot <facebook-github-bot@users.noreply.github.com> | |
| Tue, 4 Aug 2020 18:01:41 +0000 (4 11:01 -0700) | ||
| tree | e888028e36a2ed043dfc34b5cd702a7469517b77 | treesnapshot (tar.gz zip) |
| parent | 9b3b3b4cb3c3997e0dfb2e2fc32cbbb3e95b9d3f | commitdiff |
telemetry for serverMain.ml
Summary:
This diff adds detailed telemetry for ServerMain's recheck loop. I also caused this telemetry to be logged in `HackEventLogger.recheck_end`, and to the server log.
My principle for what to log:
1. Every single operation that looks like it might take a long time, should have timing information in the logs.
2. Every piece of information which used to be logged to Hh_logger or to individual subsidiary HackEventLogger events should also be stored in the Telemetry.t object which bubbles up to the top level. That will make it easier for us to correlate things.
Reviewed By: arxanas
Differential Revision: D22689367
fbshipit-source-id: 7fbe4a829bfdb61c6e5ac1c5fdb2b3a3ed4325a3
Summary:
This diff adds detailed telemetry for ServerMain's recheck loop. I also caused this telemetry to be logged in `HackEventLogger.recheck_end`, and to the server log.
My principle for what to log:
1. Every single operation that looks like it might take a long time, should have timing information in the logs.
2. Every piece of information which used to be logged to Hh_logger or to individual subsidiary HackEventLogger events should also be stored in the Telemetry.t object which bubbles up to the top level. That will make it easier for us to correlate things.
Reviewed By: arxanas
Differential Revision: D22689367
fbshipit-source-id: 7fbe4a829bfdb61c6e5ac1c5fdb2b3a3ed4325a3