Move function and method attribute check ahead of reactivity check
commit04db05e8fb36345ed089d23434a186beb8fe742f
authorVassil Mladenov <vmladenov@fb.com>
Mon, 7 May 2018 22:39:34 +0000 (7 15:39 -0700)
committerHhvm Bot <hhvm-bot@users.noreply.github.com>
Mon, 7 May 2018 22:51:04 +0000 (7 15:51 -0700)
tree4cf09b11d370d28c78a2bdc9b482e66951bcc714
parent599a64333860f075cadfba170fe1c7b7d38c9631
Move function and method attribute check ahead of reactivity check

Summary: The check was happening too late and conflicting with the __Rx/__RxShallow attribute

Reviewed By: alexchow

Differential Revision: D7886047

fbshipit-source-id: 4e8c9207c60d6c08b6479a32ce2ffee3089d02a2
hphp/hack/src/typing/typing.ml
hphp/hack/test/typecheck/attributes/reactivity_check.php [new file with mode: 0644]
hphp/hack/test/typecheck/attributes/reactivity_check.php.exp [new file with mode: 0644]