Fix case insensitivity of PHP keywords
commit048ba2c9ce697a78fadcc920450c5341b1c15f16
authorJames Wu <jjwu@fb.com>
Tue, 15 May 2018 18:51:38 +0000 (15 11:51 -0700)
committerHhvm Bot <hhvm-bot@users.noreply.github.com>
Tue, 15 May 2018 19:10:09 +0000 (15 12:10 -0700)
treed0d7700a9cbc170944f23ff8b4b7a6c8a01a0e7e
parentc54b34b121df5cd8eb652356d9b52445b6c8d3ab
Fix case insensitivity of PHP keywords

Summary:
This changes all PHP keywords + a few Hack ones to be case insensitive.

Words like "dynamic" and "mixed" which are only valid keywords in PHP will mostly stay case sensitive(I changed a few of them anyway before I decided it was too annoying), but PHP builtins will be case insensitive after this diff.

Fixes https://github.com/facebook/hhvm/issues/8194

Reviewed By: oulgen, alexeyt

Differential Revision: D7958203

fbshipit-source-id: cdd83616d2fb2ab1c5340cf8171aba3085f3bfe8
37 files changed:
hphp/hack/src/hhbc/emit_expression.ml
hphp/hack/src/hhbc/emit_statement.ml
hphp/hack/src/hhbc/emit_type_hint.ml
hphp/hack/src/hhbc/hhbc_id.ml
hphp/hack/src/parser/full_fidelity_lexer.ml
hphp/test/hhcodegen_failing_tests_slow
hphp/test/slow/parser/is_a.php [moved from hphp/test/zend/good/Zend/tests/is_a.php with 62% similarity]
hphp/test/slow/parser/is_a.php.expectf [moved from hphp/test/zend/good/Zend/tests/is_a.php.expectf with 100% similarity]
hphp/test/slow/parser/is_a.php.ini [moved from hphp/test/zend/good/Zend/tests/is_a.php.ini with 100% similarity]
hphp/test/slow/parser/is_a.php.norepo [moved from hphp/test/zend/good/Zend/tests/is_a.php.norepo with 100% similarity]
hphp/test/slow/parser/keyword_as_class_name.php [new file with mode: 0644]
hphp/test/slow/parser/keyword_as_class_name.php.expect [new file with mode: 0644]
hphp/test/slow/parser/keyword_case/basic.php.skipif [deleted file]
hphp/test/slow/parser/keyword_case/class.php.skipif [deleted file]
hphp/test/slow/parser/keyword_case/control_flow.php.skipif [deleted file]
hphp/test/slow/parser/keyword_case/eval.php.skipif [deleted file]
hphp/test/slow/parser/keyword_case/exception.php.skipif [deleted file]
hphp/test/slow/parser/keyword_case/hack_async_await.php [deleted file]
hphp/test/slow/parser/keyword_case/hack_async_await.php.skipif [deleted file]
hphp/test/slow/parser/keyword_case/hack_containers.php [deleted file]
hphp/test/slow/parser/keyword_case/hack_containers.php.expect [deleted file]
hphp/test/slow/parser/keyword_case/hack_containers.php.skipif [deleted file]
hphp/test/slow/parser/keyword_case/hack_generics.php
hphp/test/slow/parser/keyword_case/hack_generics.php.skipif [deleted file]
hphp/test/slow/parser/keyword_case/hack_inout.php.skipif [deleted file]
hphp/test/slow/parser/keyword_case/hack_type_newtype.php [deleted file]
hphp/test/slow/parser/keyword_case/hack_type_newtype.php.expect [deleted file]
hphp/test/slow/parser/keyword_case/hack_type_newtype.php.ini [deleted file]
hphp/test/slow/parser/keyword_case/hack_type_newtype.php.skipif [deleted file]
hphp/test/slow/parser/keyword_case/hack_using.php.skipif [deleted file]
hphp/test/slow/parser/keyword_case/hack_xhp.php [deleted file]
hphp/test/slow/parser/keyword_case/hack_xhp.php.expect [deleted file]
hphp/test/slow/parser/keyword_case/hack_xhp.php.skipif [deleted file]
hphp/test/slow/parser/keyword_case/include.php.skipif [deleted file]
hphp/test/slow/parser/keyword_case/misc.php.skipif [deleted file]
hphp/test/slow/parser/keyword_case/namespace.php.skipif [deleted file]
hphp/test/slow/parser/keyword_case/old_ends.php.skipif [deleted file]