| commit | 033da09347c8c15a901edfaf5d8fa9e731b2585b | |
| author | Max Wang <mwang@fb.com> | |
| Fri, 30 Aug 2019 06:07:31 +0000 (29 23:07 -0700) | ||
| committer | Hhvm Bot <hhvm-bot@users.noreply.github.com> | |
| Fri, 30 Aug 2019 06:11:51 +0000 (29 23:11 -0700) | ||
| tree | aaf889fc1d1da06d082afb156ae49a6f6dbdad9e | treesnapshot (tar.gz zip) |
| parent | c125d069b355837cb13effe6dda2ecfdb7744c2a | commitdiff |
Move all arrprov instrumentation into {Packed,Mixed}Array
Summary:
This reduces the surface area of instrumentation and gives us a lot more
coverage by default, especially if we enable VM reg sync for native
calls by default. It replaces all the other runtime provenance tagging
callsites.
The only cost is that we incur some non-taken branches and code in paths
which before we could avoid by handling the checks in the JIT... but if
we want correctness by default for, e.g., all builtins, including those
which don't use the preferred array interfaces (e.g., ArrayInit), we
can't really avoid that anyway.
Reviewed By: jjgriego
Differential Revision: D17090670
fbshipit-source-id: eb5b521335e061bdf89ab5563501742d6dd2f33d
Summary:
This reduces the surface area of instrumentation and gives us a lot more
coverage by default, especially if we enable VM reg sync for native
calls by default. It replaces all the other runtime provenance tagging
callsites.
The only cost is that we incur some non-taken branches and code in paths
which before we could avoid by handling the checks in the JIT... but if
we want correctness by default for, e.g., all builtins, including those
which don't use the preferred array interfaces (e.g., ArrayInit), we
can't really avoid that anyway.
Reviewed By: jjgriego
Differential Revision: D17090670
fbshipit-source-id: eb5b521335e061bdf89ab5563501742d6dd2f33d
15 files changed: