Remove support for __get, __set, __isset and __unset from HHVM
commit02ea99f082288acce003c1a87ed42cb32562c1f7
authorJan Oravec <jan@fb.com>
Thu, 30 Apr 2020 18:27:43 +0000 (30 11:27 -0700)
committerFacebook GitHub Bot <facebook-github-bot@users.noreply.github.com>
Thu, 30 Apr 2020 21:25:46 +0000 (30 14:25 -0700)
treece2e2106f188b64a0282f71d91e4b8b225b8adf9
parent84b50453d5ac66d94fb2c6600ff6da4cd1ccd5aa
Remove support for __get, __set, __isset and __unset from HHVM

Summary:
As of the previous diff, these magic methods cannot be defined. So, remove
the logic that invokes them.

There is no expected performance win, as expensive ratcheting can't be
optimized away for objects of unknown classes, as native property handlers
still exist.

Reviewed By: oulgen

Differential Revision: D21322010

fbshipit-source-id: 2ed1eb1dda487b8797bfdc2ead7d888f32f4e422
13 files changed:
hphp/hhbbc/index.cpp
hphp/hhbbc/index.h
hphp/hhbbc/interp-internal.h
hphp/runtime/base/attr.h
hphp/runtime/base/object-data.cpp
hphp/runtime/base/object-data.h
hphp/runtime/ext/collections/ext_collections.h
hphp/runtime/vm/as-shared.cpp
hphp/runtime/vm/class-inl.h
hphp/runtime/vm/class.cpp
hphp/runtime/vm/class.h
hphp/runtime/vm/jit/irgen-minstr.cpp
hphp/runtime/vm/native-prop-handler.h