Split fields of rds::StaticMethod so method names are compared correctly
commit022af67d6b7a0c75720b29d895203488eeed61b3
authorEdwin Smith <smith@meta.com>
Fri, 13 Jan 2023 22:56:58 +0000 (13 14:56 -0800)
committerFacebook GitHub Bot <facebook-github-bot@users.noreply.github.com>
Fri, 13 Jan 2023 22:56:58 +0000 (13 14:56 -0800)
tree8ad70f50efeaaad2749ef2bad2a8a1cebeb61ac9
parent47e8e41a94bbd89907dd4c55a6147c9782799e8d
Split fields of rds::StaticMethod so method names are compared correctly

Summary:
Method names are case sensitive, so the practice of formatting a qualified
name that combines class + method, then comparing qualified names,
is buggy:
* isame() is wrong for the method name part
* same() is wrong for the class name part(s)

Reviewed By: oulgen

Differential Revision: D42485330

fbshipit-source-id: 4faab85f25a7691f43bdfd67380700ae75aab0d8
hphp/runtime/base/rds-symbol.cpp
hphp/runtime/base/rds-symbol.h
hphp/runtime/vm/jit/irlower-lookup-method.cpp
hphp/runtime/vm/jit/target-cache.cpp
hphp/runtime/vm/jit/target-cache.h