Remove side-effecting variants from `typing_phase`
commit0070b5f72fcecfb7db155eae404ecd26aaa55817
authorMichael Thomas <mjt@fb.com>
Tue, 15 Mar 2022 18:13:13 +0000 (15 11:13 -0700)
committerFacebook GitHub Bot <facebook-github-bot@users.noreply.github.com>
Tue, 15 Mar 2022 18:13:13 +0000 (15 11:13 -0700)
tree6174c8f82d37cf447f4039415d029ed267f6bfe2
parent8f16cbb9bdfe666045e1a6d66091731426d2a5b2
Remove side-effecting variants from `typing_phase`

Summary: Removes side effecting variants, removes `_with_ty_err` suffix from pure variants and updates call sites

Reviewed By: CatherineGasnier

Differential Revision: D34720245

fbshipit-source-id: a5c601cc576cd0e06e3710965c1a57a74c5a2077
32 files changed:
hphp/hack/src/lints/linter_equality_check.ml
hphp/hack/src/typing/nastInitCheck.ml
hphp/hack/src/typing/tast_env.ml
hphp/hack/src/typing/type_validator.ml
hphp/hack/src/typing/typing.ml
hphp/hack/src/typing/typing_coeffects.ml
hphp/hack/src/typing/typing_dynamic.ml
hphp/hack/src/typing/typing_enum.ml
hphp/hack/src/typing/typing_env_from_def.ml
hphp/hack/src/typing/typing_extends.ml
hphp/hack/src/typing/typing_exts.ml
hphp/hack/src/typing/typing_kinding.ml
hphp/hack/src/typing/typing_local_ops.ml
hphp/hack/src/typing/typing_memoize.ml
hphp/hack/src/typing/typing_object_get.ml
hphp/hack/src/typing/typing_ops.ml
hphp/hack/src/typing/typing_param.ml
hphp/hack/src/typing/typing_phase.ml
hphp/hack/src/typing/typing_phase.mli
hphp/hack/src/typing/typing_requirements.ml
hphp/hack/src/typing/typing_shapes.ml
hphp/hack/src/typing/typing_structure.ml
hphp/hack/src/typing/typing_subtype.ml
hphp/hack/src/typing/typing_subtype_method.ml
hphp/hack/src/typing/typing_taccess.ml
hphp/hack/src/typing/typing_tdef.ml
hphp/hack/src/typing/typing_toplevel.ml
hphp/hack/src/typing/typing_type_wellformedness.ml
hphp/hack/src/typing/typing_typedef.ml
hphp/hack/src/typing/typing_utils.ml
hphp/hack/src/typing/typing_utils.mli
hphp/hack/src/typing/typing_xhp.ml