| commit | 001c1677dff75ae0ede537f8449cf5b7729fc65c | |
| author | Sasha Manzyuk <manzyuk@fb.com> | |
| Fri, 20 Jul 2018 12:11:11 +0000 (20 05:11 -0700) | ||
| committer | Hhvm Bot <hhvm-bot@users.noreply.github.com> | |
| Fri, 20 Jul 2018 12:26:48 +0000 (20 05:26 -0700) | ||
| tree | 27262169fd704f82a2e74420c79488bdf5345837 | treesnapshot (tar.gz zip) |
| parent | e4c33a09ad79053904ffba9d2c9f2876435a0e9a | commitdiff |
Move redundant nullsafe property access check out of typing.ml
Summary: We have a check in `typing.ml` if `?->`, nullsafe property access operator, is used on a value that is guaranteed to not be null. This check better belongs into a TAST check (and shouldn't be a type error anyway because a value of type `C` can be viewed as a value of type `?C` by subsumption and hence it should be possible to use `?->` on it).
Reviewed By: andrewjkennedy
Differential Revision: D8893174
fbshipit-source-id: ff5d65537c3cb0ae40c3b270e750e1ad39163082
Summary: We have a check in `typing.ml` if `?->`, nullsafe property access operator, is used on a value that is guaranteed to not be null. This check better belongs into a TAST check (and shouldn't be a type error anyway because a value of type `C` can be viewed as a value of type `?C` by subsumption and hence it should be possible to use `?->` on it).
Reviewed By: andrewjkennedy
Differential Revision: D8893174
fbshipit-source-id: ff5d65537c3cb0ae40c3b270e750e1ad39163082