From d99b8acd1c163f7139200bd21758e2787fa3c45c Mon Sep 17 00:00:00 2001 From: Andrew Bartlett Date: Wed, 3 Sep 2014 14:53:36 +1200 Subject: [PATCH] do not dereference NULL pointer modules if we do not have dlopen Signed-off-by: Andrew Bartlett --- lib/krb5/plugin.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/lib/krb5/plugin.c b/lib/krb5/plugin.c index 8a7b85c0e..f97c513af 100644 --- a/lib/krb5/plugin.c +++ b/lib/krb5/plugin.c @@ -538,7 +538,7 @@ _krb5_plugin_run_f(krb5_context context, krb5_error_code (KRB5_LIB_CALL *func)(krb5_context, const void *, void *, void *)) { heim_string_t m = heim_string_create(module); - heim_dict_t dict; + heim_dict_t dict = NULL; void *plug_ctx; struct common_plugin_method *cpm; struct iter_ctx s; @@ -561,7 +561,9 @@ _krb5_plugin_run_f(krb5_context context, s.ret = KRB5_PLUGIN_NO_HANDLE; /* Get loaded plugins */ - dict = heim_dict_copy_value(modules, m); + if (modules) + dict = heim_dict_copy_value(modules, m); + heim_release(m); /* Add loaded plugins to s.result array */ @@ -603,7 +605,8 @@ _krb5_plugin_run_f(krb5_context context, heim_release(s.result); heim_release(s.n); - heim_release(dict); + if (dict) + heim_release(dict); return s.ret; } -- 2.11.4.GIT