From a8b2986b48a5aeba2f9680de6519ed6d35dcc608 Mon Sep 17 00:00:00 2001 From: Jeffrey Altman Date: Thu, 3 Mar 2022 09:55:46 -0500 Subject: [PATCH] lib/krb5: make/copy principal init output to NULL Initialize output principal pointer to NULL in case of failure. Change-Id: Iaf7b204d33ddf28cdbadcceac2cb8a96ac0bdd94 --- lib/krb5/principal.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/lib/krb5/principal.c b/lib/krb5/principal.c index 525feae9c..929868e63 100644 --- a/lib/krb5/principal.c +++ b/lib/krb5/principal.c @@ -789,6 +789,9 @@ krb5_make_principal(krb5_context context, krb5_error_code ret; krb5_realm r = NULL; va_list ap; + + *principal = NULL; + if(realm == NULL) { ret = krb5_get_default_realm(context, &r); if(ret) @@ -943,7 +946,11 @@ krb5_copy_principal(krb5_context context, krb5_const_principal inprinc, krb5_principal *outprinc) { - krb5_principal p = malloc(sizeof(*p)); + krb5_principal p; + + *outprinc = NULL; + + p = malloc(sizeof(*p)); if (p == NULL) return krb5_enomem(context); if(copy_Principal(inprinc, p)) { -- 2.11.4.GIT