| commit | 5f63215d0d82678233fdfb1c07f4b421f57c528b | |
| author | Nicolas Williams <nico@twosigma.com> | |
| Mon, 15 Nov 2021 05:52:50 +0000 (14 23:52 -0600) | ||
| committer | Jeffrey Altman <jaltman@auristor.com> | |
| Thu, 25 Nov 2021 03:30:44 +0000 (24 22:30 -0500) | ||
| tree | fbc5cda723a0789fc0b32a9de665a7f0d3f84838 | treesnapshot (tar.gz zip) |
| parent | 02200d55eaf01a3a21d52eccfa7eea02f9e8df72 | commitdiff |
Always perform == or != operation on cmp function result
Although not required to address bad code generation in
some versions of gcc 9 and 10, a coding style that requires
explicit comparison of the result to zero before use is
both clearer and would have avoided the generation of bad
code.
This change converts all use of cmp function usage from
```
if (strcmp(a, b) || !strcmp(c, d)) ...
```
to
```
if (strcmp(a, b) != 0 || strcmp(c, d)) == 0
```
for all C library cmp functions and related:
- strcmp(), strncmp()
- strcasecmp(), strncasecmp()
- stricmp(), strnicmp()
- memcmp()
Change-Id: Ic60c15e1e3a07e4faaf10648eefe3adae2543188
Although not required to address bad code generation in
some versions of gcc 9 and 10, a coding style that requires
explicit comparison of the result to zero before use is
both clearer and would have avoided the generation of bad
code.
This change converts all use of cmp function usage from
```
if (strcmp(a, b) || !strcmp(c, d)) ...
```
to
```
if (strcmp(a, b) != 0 || strcmp(c, d)) == 0
```
for all C library cmp functions and related:
- strcmp(), strncmp()
- strcasecmp(), strncasecmp()
- stricmp(), strnicmp()
- memcmp()
Change-Id: Ic60c15e1e3a07e4faaf10648eefe3adae2543188
46 files changed: