Remove Options::isSet()
commit86f86f19d985cd5516b5f8bd5d3dab4760d4b573
authorTeemu Murtola <teemu.murtola@gmail.com>
Sun, 19 Jul 2015 14:38:43 +0000 (19 17:38 +0300)
committerTeemu Murtola <teemu.murtola@gmail.com>
Sat, 25 Jul 2015 15:28:58 +0000 (25 17:28 +0200)
treedb40fa461882991b5fbe1a9c1a7143c75e1bd600
parentbd8ff104f5c56e7040041a456a349dac48bf60d9
Remove Options::isSet()

Replace uses with alternative means.  Add storeIsSet() to all options to
make it convenient to just check whether an option is set.
Remove Options parameters from methods where its only purpose was to
provide access to isSet(), reducing exposure of the concrete class and
making the interface cleaner.

Change-Id: If1207c8cf3af86e306c52748f8878480e35e2fc0
23 files changed:
src/gromacs/commandline/cmdlinemodulemanager-impl.h
src/gromacs/commandline/cmdlinemodulemanager.cpp
src/gromacs/commandline/cmdlineoptionsmodule.cpp
src/gromacs/commandline/cmdlineoptionsmodule.h
src/gromacs/commandline/pargs.cpp
src/gromacs/commandline/tests/cmdlinemodulemanagertest.h
src/gromacs/gmxpreprocess/insert-molecules.cpp
src/gromacs/options/abstractoption.cpp
src/gromacs/options/abstractoption.h
src/gromacs/options/abstractoptionstorage.h
src/gromacs/options/options.cpp
src/gromacs/options/options.h
src/gromacs/options/tests/optionsassigner.cpp
src/gromacs/trajectoryanalysis/analysismodule.cpp
src/gromacs/trajectoryanalysis/analysismodule.h
src/gromacs/trajectoryanalysis/cmdlinerunner.cpp
src/gromacs/trajectoryanalysis/modules/angle.cpp
src/gromacs/trajectoryanalysis/modules/rdf.cpp
src/gromacs/trajectoryanalysis/modules/select.cpp
src/gromacs/trajectoryanalysis/runnercommon.cpp
src/gromacs/trajectoryanalysis/runnercommon.h
src/testutils/refdata.cpp
src/testutils/refdata.h