| commit | 302423d06eb588245eb6496341a4ba0a5f438c59 | |
| author | Teemu Murtola <teemu.murtola@gmail.com> | |
| Sun, 6 Sep 2015 03:35:41 +0000 (6 06:35 +0300) | ||
| committer | Gerrit Code Review <gerrit@gerrit.gromacs.org> | |
| Mon, 12 Oct 2015 10:47:26 +0000 (12 12:47 +0200) | ||
| tree | 2ecf98e8416177c9a3af7129d3a9024e16577c36 | treesnapshot (tar.gz zip) |
| parent | ee0426031a37f77ce3e3d11dc1a81236210b07ea | commitdiff |
Hide implementation details from cmdlinerunner.h
Now that the tests no longer need access to an actual
TrajectoryAnalysisCommandLineRunner instance, move the
ICommandLineOptionsModule inheritance into an internal class declared in
the source file. The header only provides static functions, including a
factory that returns an ICommandLineOptionsModule for use in tests.
Remove an unused function from the header.
This simplifies the code in cmdlinerunner.cpp; now the runner is only
~100 lines of code, and only the run() method has a significant amount
of code that could be simplified (some minor gains could still be
achieved elswhere, but not much).
Change-Id: I49da8f71b2107d0a4f8c4731a14345eaaee276a8
Now that the tests no longer need access to an actual
TrajectoryAnalysisCommandLineRunner instance, move the
ICommandLineOptionsModule inheritance into an internal class declared in
the source file. The header only provides static functions, including a
factory that returns an ICommandLineOptionsModule for use in tests.
Remove an unused function from the header.
This simplifies the code in cmdlinerunner.cpp; now the runner is only
~100 lines of code, and only the run() method has a significant amount
of code that could be simplified (some minor gains could still be
achieved elswhere, but not much).
Change-Id: I49da8f71b2107d0a4f8c4731a14345eaaee276a8