From f05f870b694fef1c586289fa9721a4975215b476 Mon Sep 17 00:00:00 2001
From: Teemu Murtola <teemu.murtola@gmail.com>
Date: Sat, 14 Nov 2015 22:08:53 +0200
Subject: [PATCH] Fix reporting of unused cycle suppressions

Now also dependencies that do not exist at all are reported as unused
suppressions.  There was already one unnecessary suppression.

Change-Id: I75b16743789121c4b7ab6c92850e1a6a39f88059
---
 docs/doxygen/cycle-suppressions.txt | 1 -
 docs/doxygen/gmxtree.py             | 3 +++
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/docs/doxygen/cycle-suppressions.txt b/docs/doxygen/cycle-suppressions.txt
index 5fe2068efe..c65329275d 100644
--- a/docs/doxygen/cycle-suppressions.txt
+++ b/docs/doxygen/cycle-suppressions.txt
@@ -13,7 +13,6 @@ mdlib -> imd
 mdlib -> ewald
 mdlib -> pulling
 legacyheaders -> swap
-legacyheaders -> fileio
 timing -> legacyheaders
 timing -> gmxlib
 topology -> fileio
diff --git a/docs/doxygen/gmxtree.py b/docs/doxygen/gmxtree.py
index 5d9ac1e81e..54f36503c4 100644
--- a/docs/doxygen/gmxtree.py
+++ b/docs/doxygen/gmxtree.py
@@ -1042,6 +1042,9 @@ class GromacsTree(object):
                 for dep in firstmodule.get_dependencies():
                     if dep.get_other_module() == secondmodule:
                         dep.set_cycle_suppression()
+                        break
+                else:
+                    self._reporter.cyclic_issue("unused cycle suppression: {0}".format(line))
 
     def report_unused_cycle_suppressions(self, reporter):
         """Reports unused cycle suppressions."""
-- 
2.11.4.GIT