From c2ef7de5fafde4326ffef860210e7d7e61ff9308 Mon Sep 17 00:00:00 2001 From: Paul Bauer Date: Wed, 3 Oct 2018 18:46:31 +0200 Subject: [PATCH] Workaround for ICC postsubmit bug Disables the death test that is currently failing in post-submit for intel. I also saw that another test dies in the trajectoryanalysis suit, and that a number of builds failed with internal compiler errors. But I'm at a loss about the reason there. Change-Id: I9a9eaebb7120dc24e671a4c32b31372a17e02518 --- src/gromacs/compat/tests/pointers.cpp | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/gromacs/compat/tests/pointers.cpp b/src/gromacs/compat/tests/pointers.cpp index f96d8f57fa..62b0cd5d5e 100644 --- a/src/gromacs/compat/tests/pointers.cpp +++ b/src/gromacs/compat/tests/pointers.cpp @@ -62,9 +62,16 @@ TEST(NotNullConstruction, Works) std::make_shared(10)); #ifndef NDEBUG +/* The workaround here is needed because the intel implementation + * will not trigger the assert when using the pointer without + * a valid object. This was needed due to an internal error + * being triggered instead with the compiler under this condition. + */ +#if !defined(__INTEL_COMPILER) || !(__INTEL_COMPILER == 1800 && __INTEL_COMPILER_UPDATE == 0) int *nullPointer = nullptr; EXPECT_DEATH_IF_SUPPORTED(not_null invalidNullPointer(nullPointer), ""); #endif +#endif int value = 20; int *validPointer = &value; -- 2.11.4.GIT