Stop moving from unique_ptr when copy elision works
commit7e264cc62945b431adf8ce6308210e05efdc2822
authorMark Abraham <mark.j.abraham@gmail.com>
Tue, 3 Nov 2015 20:32:18 +0000 (3 21:32 +0100)
committerGerrit Code Review <gerrit@gerrit.gromacs.org>
Wed, 4 Nov 2015 05:02:26 +0000 (4 06:02 +0100)
tree0c7b64116b8725b18e7386bd687a98b141a9e8b6
parent1a78c291548686d4335ad674ef6eef520a39a1a2
Stop moving from unique_ptr when copy elision works

clang-3.7 warns that these std::move calls prevent the copy-elision
optimization that is permitted for returns of named values. Now that
these pointers are always std::unique_ptr, we have no need of the
std::move anyway.

Change-Id: I0bc777bfdb19c6f33a3679d03dc2b71ee79a5c46
src/gromacs/analysisdata/datastorage.cpp
src/gromacs/selection/parsetree.h
src/gromacs/selection/selectioncollection.cpp