Remove SelectionOptionBehavior::useDefaultGroups
commit641bf02fcd6d9a2784a2e189e607a95565a33f8c
authorTeemu Murtola <teemu.murtola@gmail.com>
Sat, 5 Sep 2015 07:04:38 +0000 (5 10:04 +0300)
committerTeemu Murtola <teemu.murtola@gmail.com>
Sat, 3 Oct 2015 12:17:19 +0000 (3 14:17 +0200)
tree51afcc53bc9e5c00f0dae746d62034c89c1cc6ae
parent7abd8249ac9c376c34f835d346034f53f01e702a
Remove SelectionOptionBehavior::useDefaultGroups

Instead of passing a boolean through multiple levels from test code,
make SelectionOptionBehavior only load the index groups or generate the
default index groups if they are actually required (either explicitly
used by the selections, or for interactive prompting).  Since the tests
provide all the selections through options and not through the prompt,
this also avoids the unnecessary overhead for tests, and avoids
duplicating the code to pass the flag to all users for
SelectionOptionBehavior.

Change-Id: Iedf377e6cefdead402bc1cdd3edc698bc7e65980
src/gromacs/selection/selectioncollection.cpp
src/gromacs/selection/selectioncollection.h
src/gromacs/selection/selectionoptionbehavior.cpp
src/gromacs/selection/selectionoptionbehavior.h
src/gromacs/selection/selectionoptionmanager.cpp
src/gromacs/selection/selectionoptionmanager.h
src/gromacs/selection/selelem.cpp
src/gromacs/selection/selelem.h
src/gromacs/trajectoryanalysis/cmdlinerunner.cpp
src/gromacs/trajectoryanalysis/cmdlinerunner.h
src/gromacs/trajectoryanalysis/tests/moduletest.cpp