| commit | 5a8f6ac76d9f1d8bca5c98228b65d85ffb3b9c13 | |
| author | Mark Abraham <mark.j.abraham@gmail.com> | |
| Mon, 3 Oct 2016 10:00:52 +0000 (3 12:00 +0200) | ||
| committer | Mark Abraham <mark.j.abraham@gmail.com> | |
| Mon, 3 Oct 2016 12:31:30 +0000 (3 14:31 +0200) | ||
| tree | e096e43a6e015d273d85718ea3ea601995ca1ff4 | treesnapshot (tar.gz zip) |
| parent | a177da89afd703a188f29a655d3acbf3329d6874 | commitdiff |
Replace use of deprecated readdir_r
clang 3.8+ warn about the deprecation of readdir_r. The main issue
here is support for concurrent access to the same directory stream,
which is never something GROMACS is likely to do. Currently the only
use is implementing enumerateFilesWithExtension which is used
single-threaded by pdb2gmx for discovering force fields in the
database. So we can replace the use of readdir_r with readdir, which
is simpler, and offers other advantages listed in man readdir_r.
Documented the new restriction on the interface of
DirectoryEnumerator. There are no current uses of nextFile that
would be affected by the change.
Change-Id: I0b80554493ff80e8857f0431192e22cfe7db5b22
clang 3.8+ warn about the deprecation of readdir_r. The main issue
here is support for concurrent access to the same directory stream,
which is never something GROMACS is likely to do. Currently the only
use is implementing enumerateFilesWithExtension which is used
single-threaded by pdb2gmx for discovering force fields in the
database. So we can replace the use of readdir_r with readdir, which
is simpler, and offers other advantages listed in man readdir_r.
Documented the new restriction on the interface of
DirectoryEnumerator. There are no current uses of nextFile that
would be affected by the change.
Change-Id: I0b80554493ff80e8857f0431192e22cfe7db5b22
| src/gromacs/utility/directoryenumerator.cpp | diffblobblamehistory | |
| src/gromacs/utility/directoryenumerator.h | diffblobblamehistory |