Fix issues for clang-analyzer-8
commit2cafe3dbdf335f76750d6ab90a03b0d58ab6a3a9
authorMark Abraham <mark.j.abraham@gmail.com>
Tue, 13 Aug 2019 14:48:40 +0000 (13 16:48 +0200)
committerMark Abraham <mark.j.abraham@gmail.com>
Tue, 20 Aug 2019 08:38:37 +0000 (20 10:38 +0200)
tree19bbf8ea789cf757d489fc03595be2765ac3d2e6
parent0ffe6ec5d891b3b5e7084666145b522c8c6fd440
Fix issues for clang-analyzer-8

pdb2gmx can no longer attempt to add a vsite after issuing a warning
that it cannot convert an atom, instead exiting with a fatal error.

Fixed bug in gmx order -calcdist

Suppressed some analyzer leak warnings of gmock objects. If the leaks
are real, ASAN will really find it, and if not we aren't going to fix
it in gmock.

Change-Id: Ib3290d7722c1e719ce5291cf3db68a87bc7ce89a
34 files changed:
admin/builds/clang-analyzer.py
docs/release-notes/2020/major/tools.rst
src/external/thread_mpi/src/comm.cpp
src/gromacs/analysisdata/tests/mock_datamodule.cpp
src/gromacs/awh/awh.cpp
src/gromacs/domdec/domdec.cpp
src/gromacs/domdec/partition.cpp
src/gromacs/ewald/pme_spread.cpp
src/gromacs/fft/fft5d.cpp
src/gromacs/fileio/matio.cpp
src/gromacs/gmxana/gmx_analyze.cpp
src/gromacs/gmxana/gmx_bar.cpp
src/gromacs/gmxana/gmx_dipoles.cpp
src/gromacs/gmxana/gmx_mindist.cpp
src/gromacs/gmxana/gmx_msd.cpp
src/gromacs/gmxana/gmx_order.cpp
src/gromacs/gmxana/gmx_wham.cpp
src/gromacs/gmxpreprocess/gen_vsite.cpp
src/gromacs/gmxpreprocess/grompp.cpp
src/gromacs/gmxpreprocess/pdb2gmx.cpp
src/gromacs/gmxpreprocess/readir.cpp
src/gromacs/listed_forces/manage_threading.cpp
src/gromacs/mdlib/lincs.cpp
src/gromacs/mdlib/mdatoms.cpp
src/gromacs/mdrun/md.cpp
src/gromacs/mdrun/rerun.cpp
src/gromacs/mdrun/shellfc.cpp
src/gromacs/mdrunutility/tests/threadaffinitytest.cpp
src/gromacs/mdrunutility/tests/threadaffinitytest.h
src/gromacs/nbnxm/grid.cpp
src/gromacs/pulling/tests/pull.cpp
src/gromacs/selection/compiler.cpp
src/gromacs/tools/pme_error.cpp
src/gromacs/trajectoryanalysis/modules/surfacearea.cpp