From f1a5a0e3c3d32bb800a0a63a0cfcd1b25a8e3d4d Mon Sep 17 00:00:00 2001 From: Joseph Myers Date: Wed, 26 Nov 2014 16:34:06 +0000 Subject: [PATCH] Fix sysdeps/mips/__longjmp.c warning. This patch fixes ../sysdeps/mips/__longjmp.c:27:1: warning: function declaration isn't a prototype [-Wstrict-prototypes] which arose I think from the MIPS16 changes (renaming the function to ____longjmp with an alias __longjmp, so a prior header prototype for __longjmp no longer sufficed to prevent a warning). I've made the function use a prototype definition, which is what we want for all function definitions in glibc anyway. Tested for MIPS. * sysdeps/mips/__longjmp.c (____longjmp): Use prototype definition. --- ChangeLog | 3 +++ sysdeps/mips/__longjmp.c | 4 +--- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/ChangeLog b/ChangeLog index 0797a15123..5ec7f0d96b 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,8 @@ 2014-11-26 Joseph Myers + * sysdeps/mips/__longjmp.c (____longjmp): Use prototype + definition. + * nptl/tst-cancel-self-cancelstate.c (do_test): Cast argument of pthread_cleanup_push to void *. diff --git a/sysdeps/mips/__longjmp.c b/sysdeps/mips/__longjmp.c index 5e6a3537b4..c2498c32c3 100644 --- a/sysdeps/mips/__longjmp.c +++ b/sysdeps/mips/__longjmp.c @@ -24,9 +24,7 @@ #endif static void __attribute__ ((nomips16)) -____longjmp (env_arg, val_arg) - __jmp_buf env_arg; - int val_arg; +____longjmp (__jmp_buf env_arg, int val_arg) { /* gcc 1.39.19 miscompiled the longjmp routine (as it did setjmp before the hack around it); force it to use $a1 for the longjmp value. -- 2.11.4.GIT