From e04a4e9d2e639a7770e1c0d24ecbcf92abf6bba8 Mon Sep 17 00:00:00 2001 From: Will Newton Date: Tue, 25 Feb 2014 14:29:32 +0000 Subject: [PATCH] stdlib/tst-setcontext.c: Check for clobbering of signal stack On aarch64 calling swapcontext clobbers the state of the signal stack (BZ #16629). Check that the address and size of the signal stack before and after the call to swapcontext remains the same. ChangeLog: 2014-04-17 Will Newton [BZ #16629] * stdlib/tst-setcontext.c: Include signal.h. (main): Check that the signal stack before and after swapcontext is the same. --- ChangeLog | 4 ++++ stdlib/tst-setcontext.c | 21 +++++++++++++++++++++ 2 files changed, 25 insertions(+) diff --git a/ChangeLog b/ChangeLog index 55dcc2b652..1dd40fcf2c 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,6 +1,10 @@ 2014-04-17 Will Newton [BZ #16629] + * stdlib/tst-setcontext.c: Include signal.h. + (main): Check that the signal stack before and + after swapcontext is the same. + * sysdeps/unix/sysv/linux/aarch64/setcontext.S (__setcontext): Re-implement to restore registers in user code and avoid rt_sigreturn system call. diff --git a/stdlib/tst-setcontext.c b/stdlib/tst-setcontext.c index ac9deb1b4f..55984a4642 100644 --- a/stdlib/tst-setcontext.c +++ b/stdlib/tst-setcontext.c @@ -16,6 +16,7 @@ . */ #include +#include #include #include #include @@ -144,6 +145,9 @@ main (void) atexit (check_called); char st1[32768]; + stack_t stack_before, stack_after; + + sigaltstack(NULL, &stack_before); puts ("making contexts"); if (getcontext (&ctx[1]) != 0) @@ -207,6 +211,8 @@ main (void) puts ("back at main program"); back_in_main = 1; + sigaltstack(NULL, &stack_after); + if (was_in_f1 == 0) { puts ("didn't reach f1"); @@ -218,6 +224,21 @@ main (void) exit (1); } + /* Check sigaltstack state is not clobbered as in BZ #16629. */ + if (stack_before.ss_sp != stack_after.ss_sp) + { + printf ("stack ss_sp mismatch: %p %p\n", + stack_before.ss_sp, stack_after.ss_sp); + exit (1); + } + + if (stack_before.ss_size != stack_after.ss_size) + { + printf ("stack ss_size mismatch: %zd %zd\n", + stack_before.ss_size, stack_after.ss_size); + exit (1); + } + puts ("test succeeded"); return 0; } -- 2.11.4.GIT