| commit | 9fa7449b35244645acaa450046b37678f46fe0f1 | |
| author | Florian Weimer <fweimer@redhat.com> | |
| Mon, 14 Aug 2017 09:44:24 +0000 (14 11:44 +0200) | ||
| committer | Florian Weimer <fweimer@redhat.com> | |
| Mon, 14 Aug 2017 13:08:48 +0000 (14 15:08 +0200) | ||
| tree | 83a87696a1e4ae4fad80f9167bb25e02c91dfe53 | treesnapshot (tar.gz zip) |
| parent | 73322d5ff6ad71c65f875095c4801771cff9ab2d | commitdiff |
_dl_fini: Remove internal_function attribute
Assembler code passes the address of _dl_fini to __libc_start_main,
whose function pointer argument lacks the attribute. This means
that calls could use the wrong ABI. Fortunately, for zero-parameter
void-returning functions, internal_function does not change ABI
on i386 (the only architecture which uses internal_function), so
this inconsistency was harmless (which is why it had not been
noticed so far).
Assembler code passes the address of _dl_fini to __libc_start_main,
whose function pointer argument lacks the attribute. This means
that calls could use the wrong ABI. Fortunately, for zero-parameter
void-returning functions, internal_function does not change ABI
on i386 (the only architecture which uses internal_function), so
this inconsistency was harmless (which is why it had not been
noticed so far).
| ChangeLog | diffblobblamehistory | |
| elf/dl-fini.c | diffblobblamehistory | |
| sysdeps/generic/ldsodefs.h | diffblobblamehistory |