Fix finite-math-only lgamma functions signgam setting (bug 19211).
commit939fdd1c36dde8884543bc9c3b8506e76c9ff0e4
authorJoseph Myers <joseph@codesourcery.com>
Thu, 5 Nov 2015 21:23:07 +0000 (5 21:23 +0000)
committerJoseph Myers <joseph@codesourcery.com>
Thu, 5 Nov 2015 21:23:07 +0000 (5 21:23 +0000)
treef2a5ec7b8209beb361b21fe0de8aede38549ec6c
parentf248238cf43bd751db29e6f151d6da7645337ff5
Fix finite-math-only lgamma functions signgam setting (bug 19211).

The lgamma inline functions in bits/math-finite.h do not set signgam
if __USE_ISOC99, even when other feature test macros mean a standard
such as XSI POSIX is selected for which it should be set.  (This is
essentially the opposite issue to bug 15421, the out-of-line versions
setting signgam even when they shouldn't.)

This patch fixes those functions to use __USE_MISC || __USE_XOPEN as
the condition for when to set signgam, since it's the condition for
when math.h declares signgam.  The legacy gamma* names are only
declared at all if __USE_MISC || __USE_XOPEN, so they just set signgam
unconditionally.

Tests for certain standards or not using _GNU_SOURCE cannot use
test-skeleton.c (this is a known issue noted on the wiki todo list).
Thus, the new tests that signgam remains not set in ISO C modes do not
use test-skeleton.c.  They also define _ISOMAC to avoid running into
declarations in the internal include/ headers that only work in
_GNU_SOURCE mode.

Tested for x86_64 and x86.

[BZ #19211]
* math/bits/math-finite.h (lgamma): Set signgam if [__USE_MISC ||
__USE_XOPEN], not if [!__USE_ISOC99].
(lgammaf): Likewise.
(lgammal): Likewise.
(gamma): Set signgam unconditionally, not if [!__USE_ISOC99].
(gammaf): Likewise.
(gammal): Likewise.
* math/test-signgam-finite-c11.c: New file.
* math/test-signgam-finite-c99.c: Likewise.
* math/test-signgam-finite.c: Likewise.
* math/Makefile (tests): Add test-signgam-finite,
test-signgam-finite-c99 and test-signgam-finite-c11.
(CFLAGS-test-signgam-finite.c): New variable.
(CFLAGS-test-signgam-finite-c99.c): Likewise.
(CFLAGS-test-signgam-finite-c11.c): Likewise.
ChangeLog
NEWS
math/Makefile
math/bits/math-finite.h
math/test-signgam-finite-c11.c [new file with mode: 0644]
math/test-signgam-finite-c99.c [new file with mode: 0644]
math/test-signgam-finite.c [new file with mode: 0644]