Fix crypt snprintf namespace (bug 20829).
commit61158ffa9a17476d88aaf4a833d13b12f1c51387
authorJoseph Myers <joseph@codesourcery.com>
Wed, 16 Nov 2016 22:46:48 +0000 (16 22:46 +0000)
committerJoseph Myers <joseph@codesourcery.com>
Wed, 16 Nov 2016 22:46:48 +0000 (16 22:46 +0000)
tree2113e63413caa6d97c0e9bf0b905afbfd4a7eee0
parent7773556dfb2bf62f7b6deda66fa3821a3bcdbf3e
Fix crypt snprintf namespace (bug 20829).

Extending linknamespace tests to cover libcrypt showed that crypt
brings in references to snprintf, but is in XPG3 and XPG4 which don't
have snprintf.  This patch fixes it to use __snprintf instead,
exporting __snprintf from libc.so at version GLIBC_PRIVATE and adding
libc_hidden_proto / libc_hidden_def accordingly.

Tested for x86_64 and x86, in conjunction with the testsuite changes
to enable linknamespace testing for libdl and libcrypt.  Also tested
(compilation only) for powerpc to make sure there were no problem
interactions with the optional-long-double handling for snprintf.

[BZ #20829]
* stdio-common/Versions (__snprintf): Add to version
GLIBC_PRIVATE.
* include/stdio.h (__snprintf): Use libc_hidden_proto.
* stdio-common/snprintf.c (__snprintf): Use libc_hidden_def.
* crypt/sha256-crypt.c (__sha256_crypt_r): Use __snprintf instead
of snprintf.
* crypt/sha512-crypt.c (__sha512_crypt_r): Likewise.
ChangeLog
crypt/sha256-crypt.c
crypt/sha512-crypt.c
include/stdio.h
stdio-common/Versions
stdio-common/snprintf.c