Add _STRING_INLINE_unaligned and string_private.h
commit16396c41deab45f715ffd813280d9d685b3b281e
authorH.J. Lu <hongjiu.lu@intel.com>
Thu, 18 Feb 2016 13:00:33 +0000 (18 11:00 -0200)
committerAdhemerval Zanella <adhemerval.zanella@linaro.org>
Thu, 18 Feb 2016 16:55:29 +0000 (18 14:55 -0200)
tree5ed0830f0b3524559d6a099c3a19af14223ef28a
parent6400ae6ecf6376af230d3ec82a8541848d3239e9
Add _STRING_INLINE_unaligned and string_private.h

As discussed in

https://sourceware.org/ml/libc-alpha/2015-10/msg00403.html

the setting of _STRING_ARCH_unaligned currently controls the external
GLIBC ABI as well as selecting the use of unaligned accesses withing
GLIBC.

Since _STRING_ARCH_unaligned was recently changed for AArch64, this
would potentially break the ABI in GLIBC 2.23, so split the uses and add
_STRING_INLINE_unaligned to select the string ABI. This setting must be
fixed for each target, while _STRING_ARCH_unaligned may be changed from
release to release.  _STRING_ARCH_unaligned is used unconditionally in
glibc.  But <bits/string.h>, which defines _STRING_ARCH_unaligned, isn't
included with -Os.  Since _STRING_ARCH_unaligned is internal to glibc and
may change between glibc releases, it should be made private to glibc.
_STRING_ARCH_unaligned should defined in the new string_private.h heade
file which is included unconditionally from internal <string.h> for glibc
build.

[BZ #19462]
* bits/string.h (_STRING_ARCH_unaligned): Renamed to ...
(_STRING_INLINE_unaligned): This.
* include/string.h: Include <string_private.h>.
* string/bits/string2.h: Replace _STRING_ARCH_unaligned with
_STRING_INLINE_unaligned.
* sysdeps/aarch64/bits/string.h (_STRING_ARCH_unaligned): Removed.
(_STRING_INLINE_unaligned): New.
* sysdeps/aarch64/string_private.h: New file.
* sysdeps/generic/string_private.h: Likewise.
* sysdeps/m68k/m680x0/m68020/string_private.h: Likewise.
* sysdeps/s390/string_private.h: Likewise.
* sysdeps/x86/string_private.h: Likewise.
* sysdeps/m68k/m680x0/m68020/bits/string.h
(_STRING_ARCH_unaligned): Renamed to ...
(_STRING_INLINE_unaligned): This.
* sysdeps/s390/bits/string.h (_STRING_ARCH_unaligned): Renamed
to ...
(_STRING_INLINE_unaligned): This.
* sysdeps/sparc/bits/string.h (_STRING_ARCH_unaligned): Renamed
to ...
(_STRING_INLINE_unaligned): This.
* sysdeps/x86/bits/string.h (_STRING_ARCH_unaligned): Renamed
to ...
(_STRING_INLINE_unaligned): This.
14 files changed:
ChangeLog
bits/string.h
include/string.h
string/bits/string2.h
sysdeps/aarch64/bits/string.h
sysdeps/aarch64/string_private.h [copied from sysdeps/aarch64/bits/string.h with 79% similarity]
sysdeps/generic/string_private.h [copied from sysdeps/aarch64/bits/string.h with 69% similarity]
sysdeps/m68k/m680x0/m68020/bits/string.h
sysdeps/m68k/m680x0/m68020/string_private.h [copied from sysdeps/aarch64/bits/string.h with 69% similarity]
sysdeps/s390/bits/string.h
sysdeps/s390/string_private.h [copied from sysdeps/aarch64/bits/string.h with 69% similarity]
sysdeps/sparc/bits/string.h
sysdeps/x86/bits/string.h
sysdeps/x86/string_private.h [copied from sysdeps/aarch64/bits/string.h with 69% similarity]