From bdcaa325b47fcacfecb781a28801aafc249ba288 Mon Sep 17 00:00:00 2001 From: Jonathan Nieder Date: Tue, 20 Jul 2010 19:01:01 -0500 Subject: [PATCH] t/README: correct an exception when breaking a && chain in tests The correct advice should have been taken from c289c31 (t/t7006: ignore return status of shell's unset builtin, 2010-06-02). A real-life issue we experienced was with "unset", not with "export" (exporting an unset variable may have similar portability issues, though). Signed-off-by: Junio C Hamano --- t/README | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/t/README b/t/README index a590142438..0d1183c3e6 100644 --- a/t/README +++ b/t/README @@ -259,11 +259,11 @@ Do: test ... That way all of the commands in your tests will succeed or fail. If - you must ignore the return value of something (e.g. the return - value of export is unportable) it's best to indicate so explicitly - with a semicolon: + you must ignore the return value of something (e.g., the return + after unsetting a variable that was already unset is unportable) it's + best to indicate so explicitly with a semicolon: - export HLAGH; + unset HLAGH; git merge hla && git push gh && test ... -- 2.11.4.GIT