From 1149fecfc270a2effc344897989f40afe449a72c Mon Sep 17 00:00:00 2001 From: Jakub Narebski Date: Tue, 22 Aug 2006 19:05:24 +0200 Subject: [PATCH] gitweb: Drop the href() params which keys are not in %mapping If someone would enter parameter name incorrectly, and some key of %params is not found in %mapping hash, the parameter is now ignored. Change introduced by Martin Waitz in commit 756d2f064b2419fcdf9cd9c851f352e2a4f75103 tried to do that, but it left empty value and there was doubled ";;" in returned string. Signed-off-by: Jakub Narebski Signed-off-by: Junio C Hamano --- gitweb/gitweb.perl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl index 1c8a2ebe15..43b1600486 100755 --- a/gitweb/gitweb.perl +++ b/gitweb/gitweb.perl @@ -285,7 +285,7 @@ sub href(%) { my $href = "$my_uri?"; $href .= esc_param( join(";", map { - "$mapping{$_}=$params{$_}" if defined $params{$_} + defined $params{$_} ? "$mapping{$_}=$params{$_}" : () } keys %params ) ); -- 2.11.4.GIT