From 1292df11e8063442f911b2a4d0f7213f117d54d7 Mon Sep 17 00:00:00 2001 From: Alexandru Juncu Date: Thu, 8 Aug 2013 16:17:38 +0300 Subject: [PATCH] git-p4: Fix occasional truncation of symlink contents. Symlink contents in p4 print sometimes have a trailing new line character, but sometimes it doesn't. git-p4 should only remove the last character if that character is '\n'. Signed-off-by: Alex Juncu Signed-off-by: Alex Badea Acked-by: Pete Wyckoff Signed-off-by: Junio C Hamano --- git-p4.py | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/git-p4.py b/git-p4.py index 31e71ff8b2..a53a6dc406 100755 --- a/git-p4.py +++ b/git-p4.py @@ -2180,9 +2180,13 @@ class P4Sync(Command, P4UserMap): git_mode = "100755" if type_base == "symlink": git_mode = "120000" - # p4 print on a symlink contains "target\n"; remove the newline + # p4 print on a symlink sometimes contains "target\n"; + # if it does, remove the newline data = ''.join(contents) - contents = [data[:-1]] + if data[-1] == '\n': + contents = [data[:-1]] + else: + contents = [data] if type_base == "utf16": # p4 delivers different text in the python output to -G -- 2.11.4.GIT