| commit | fd99c2dd9b0b24fe4bb36366a6b1ff9e29b29286 | |
| author | René Scharfe <l.s.r@web.de> | |
| Sun, 25 Aug 2019 13:26:40 +0000 (25 15:26 +0200) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Mon, 26 Aug 2019 18:32:28 +0000 (26 11:32 -0700) | ||
| tree | 7df8117550b21aa78a1abcf7daf89625ebe782e9 | treesnapshot (tar.gz zip) |
| parent | 82f51af3452bb80e2347bb45dba3e1d2f10d0be7 | commitdiff |
grep: use return value of strbuf_detach()
Append the strbuf buffer only after detaching it. There is no practical
difference here, as the strbuf is not empty and no strbuf_ function is
called between storing the pointer to the still attached buffer and
calling strbuf_detach(), so that pointer is valid, but make sure to
follow the standard sequence anyway for consistency.
Signed-off-by: René Scharfe <l.s.r@web.de>
Acked-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Append the strbuf buffer only after detaching it. There is no practical
difference here, as the strbuf is not empty and no strbuf_ function is
called between storing the pointer to the still attached buffer and
calling strbuf_detach(), so that pointer is valid, but make sure to
follow the standard sequence anyway for consistency.
Signed-off-by: René Scharfe <l.s.r@web.de>
Acked-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| builtin/grep.c | diffblobblamehistory |