| commit | efc749b48f729992d838484d652ba24f5291ee28 | |
| author | Jonathan Nieder <jrnieder@gmail.com> | |
| Mon, 11 Oct 2010 02:51:21 +0000 (10 21:51 -0500) | ||
| committer | Jonathan Nieder <jrnieder@gmail.com> | |
| Mon, 7 Mar 2011 07:32:51 +0000 (7 01:32 -0600) | ||
| tree | d1d410f8035f5632f5b286554df78af04c1c8250 | treesnapshot (tar.gz zip) |
| parent | e75316de5340e0ba3ac75937c59fa2c9d6ab48d7 | commitdiff |
vcs-svn: allow input errors to be detected promptly
The line_buffer library silently flags input errors until
buffer_deinit time; unfortunately, by that point usually errno is
invalid. Expose the error flag so callers can check for and
report errors early for easy debugging.
some_error_prone_operation(...);
if (buffer_ferror(buf))
return error("input error: %s", strerror(errno));
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: David Barr <david.barr@cordelta.com>
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
The line_buffer library silently flags input errors until
buffer_deinit time; unfortunately, by that point usually errno is
invalid. Expose the error flag so callers can check for and
report errors early for easy debugging.
some_error_prone_operation(...);
if (buffer_ferror(buf))
return error("input error: %s", strerror(errno));
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: David Barr <david.barr@cordelta.com>
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
| vcs-svn/line_buffer.c | diffblobblamehistory | |
| vcs-svn/line_buffer.h | diffblobblamehistory |