| commit | e9fc64c60a71a190016a9e9bcb81195a0fa0d9f4 | |
| author | Avery Pennarun <apenwarr@gmail.com> | |
| Thu, 24 May 2012 06:12:24 +0000 (24 02:12 -0400) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Thu, 24 May 2012 18:29:07 +0000 (24 11:29 -0700) | ||
| tree | 9d5586d7c51ddfe8fe30bcd599318922d501bdbe | treesnapshot (tar.gz zip) |
| parent | 17a9ac7d6b5f27eb5f8efee324e88db2b6ec9bd6 | commitdiff |
checkout: no progress messages if !isatty(2).
If stderr isn't a tty, we shouldn't be printing incremental progress
messages. In particular, this affects 'git checkout -f . >&logfile'
unless you provided -q. And git-new-workdir has no way to provide -q.
It would probably be better to have progress.c check isatty(2) all the time,
but that wouldn't allow things like 'git push --progress' to force progress
reporting to on, so I won't try to solve the general case right now.
Actual fix suggested by Jeff King.
Signed-off-by: Avery Pennarun <apenwarr@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
If stderr isn't a tty, we shouldn't be printing incremental progress
messages. In particular, this affects 'git checkout -f . >&logfile'
unless you provided -q. And git-new-workdir has no way to provide -q.
It would probably be better to have progress.c check isatty(2) all the time,
but that wouldn't allow things like 'git push --progress' to force progress
reporting to on, so I won't try to solve the general case right now.
Actual fix suggested by Jeff King.
Signed-off-by: Avery Pennarun <apenwarr@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| builtin/checkout.c | diffblobblamehistory |