t5520: replace test -f with test-lib functions
commitceeef863defcb3d48e32915b37f2d748708c9fd4
authorDenton Liu <liu.denton@gmail.com>
Tue, 12 Nov 2019 23:07:55 +0000 (12 15:07 -0800)
committerJunio C Hamano <gitster@pobox.com>
Thu, 21 Nov 2019 00:41:51 +0000 (21 09:41 +0900)
tree5cc03805b1b79920bfd6ed6e273fd812b3273d18
parent4c8b046f82cbc468fc28b6e52883a15ee2942ec7
t5520: replace test -f with test-lib functions

Although `test -f` has the same functionality as test_path_is_file(), in
the case where test_path_is_file() fails, we get much better debugging
information.

Replace `test -f` with test_path_is_file() so that future developers
will have a better experience debugging these test cases.

Also, in the case of `! test -f`, not only should that path not be a
file, it shouldn't exist at all so replace it with
test_path_is_missing().

Signed-off-by: Denton Liu <liu.denton@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
t/t5520-pull.sh