| commit | c63fe3b2dc90120a4bdba7194f92efc2f3c342ed | |
| author | Shawn O. Pearce <spearce@spearce.org> | |
| Sun, 9 Sep 2007 03:05:43 +0000 (8 23:05 -0400) | ||
| committer | Shawn O. Pearce <spearce@spearce.org> | |
| Sun, 9 Sep 2007 09:03:12 +0000 (9 05:03 -0400) | ||
| tree | a884acffca2d2cf558b593ac480966a6c88db7c8 | treesnapshot (tar.gz zip) |
| parent | cff93397ab185898fd93b6a260cc6f3068c4ac30 | commitdiff |
git-gui: Avoid use of libdir in Makefile
Dmitry V. Levin pointed out that on GNU linux libdir is often used
in Makefiles to mean "/usr/lib" or "/usr/lib64", a directory that
is meant to hold platform-specific binary files. Using a different
libdir meaning here in git-gui's Makefile breaks idomatic expressions
like rpm specifile "make libdir=%_libdir".
Originally I asked that the git.git Makefile undefine libdir before
it calls git-gui's own Makefile but it turns out this is very hard
to do, if not impossible. Renaming our libdir to gg_libdir resolves
this case with a minimum amount of fuss on our part.
Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
Dmitry V. Levin pointed out that on GNU linux libdir is often used
in Makefiles to mean "/usr/lib" or "/usr/lib64", a directory that
is meant to hold platform-specific binary files. Using a different
libdir meaning here in git-gui's Makefile breaks idomatic expressions
like rpm specifile "make libdir=%_libdir".
Originally I asked that the git.git Makefile undefine libdir before
it calls git-gui's own Makefile but it turns out this is very hard
to do, if not impossible. Renaming our libdir to gg_libdir resolves
this case with a minimum amount of fuss on our part.
Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
| Makefile | diffblobblamehistory |