| commit | afcb6ac83d8854f8cc271bb4e933836c9d4f1d3b | |
| author | John Keeping <john@keeping.me.uk> | |
| Sun, 3 Feb 2013 14:37:11 +0000 (3 14:37 +0000) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Sun, 3 Feb 2013 21:47:43 +0000 (3 13:47 -0800) | ||
| tree | 766574ff9ac7b39150a4d1a088e0f2f972768e5e | treesnapshot (tar.gz zip) |
| parent | 7e2010537e96d0a1144520222f20ba1dc3d61441 | commitdiff |
builtin/apply: tighten (dis)similarity index parsing
This was prompted by an incorrect warning issued by clang [1], and a
suggestion by Linus to restrict the range to check for values greater
than INT_MAX since these will give bogus output after casting to int.
In fact the (dis)similarity index is a percentage, so reject values
greater than 100.
[1] http://article.gmane.org/gmane.comp.version-control.git/213857
Signed-off-by: John Keeping <john@keeping.me.uk>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This was prompted by an incorrect warning issued by clang [1], and a
suggestion by Linus to restrict the range to check for values greater
than INT_MAX since these will give bogus output after casting to int.
In fact the (dis)similarity index is a percentage, so reject values
greater than 100.
[1] http://article.gmane.org/gmane.comp.version-control.git/213857
Signed-off-by: John Keeping <john@keeping.me.uk>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| builtin/apply.c | diffblobblamehistory |