| commit | 7d5e9c9849a809ff70223037bf6d569a8e2d3e66 | |
| author | Jeff King <peff@peff.net> | |
| Fri, 18 Mar 2016 06:12:01 +0000 (18 02:12 -0400) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Fri, 18 Mar 2016 21:48:36 +0000 (18 14:48 -0700) | ||
| tree | 7a11c13e1d37601d1a05bbb5ed3293931a079eba | treesnapshot (tar.gz zip) |
| parent | 937978e0f3e750d917768c77665d5f8cfbd802b6 | commitdiff |
credential-cache--daemon: clarify "exit" action semantics
When this code was originally written, there wasn't much
thought given to the timing between a client asking for
"exit", the daemon signaling that the action is done (with
EOF), and the actual cleanup of the socket.
However, we need to care about this so that our test scripts
do not end up racy (e.g., by asking for an exit and checking
that the socket was cleaned up). The code that is already
there happens to behave very reasonably; let's add a comment
to make it clear that any changes should retain the same
behavior.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
When this code was originally written, there wasn't much
thought given to the timing between a client asking for
"exit", the daemon signaling that the action is done (with
EOF), and the actual cleanup of the socket.
However, we need to care about this so that our test scripts
do not end up racy (e.g., by asking for an exit and checking
that the socket was cleaned up). The code that is already
there happens to behave very reasonably; let's add a comment
to make it clear that any changes should retain the same
behavior.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| credential-cache--daemon.c | diffblobblamehistory |