| commit | 792f8119986bd354eb4ea0858dfd45904120c257 | |
| author | Jeff King <peff@peff.net> | |
| Fri, 14 Feb 2020 18:22:18 +0000 (14 13:22 -0500) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Fri, 14 Feb 2020 18:46:22 +0000 (14 10:46 -0800) | ||
| tree | e2222f3c9d3445258c3dc238c499925ea4b5fd23 | treesnapshot (tar.gz zip) |
| parent | d90fe06ea7dd15bdbd555ad2f4bfdd069032b697 | commitdiff |
rev-list: factor out bitmap-optimized routines
There are a few operations in rev-list that are optimized for bitmaps.
Rather than having the code inline in cmd_rev_list(), let's move them
into helpers. This not only makes the flow of the main function simpler,
but it lets us replace the complex "can we do the optimization?"
conditionals with a series of early returns from the functions. That
also makes it easy to add comments explaining those conditions.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
There are a few operations in rev-list that are optimized for bitmaps.
Rather than having the code inline in cmd_rev_list(), let's move them
into helpers. This not only makes the flow of the main function simpler,
but it lets us replace the complex "can we do the optimization?"
conditionals with a series of early returns from the functions. That
also makes it easy to add comments explaining those conditions.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| builtin/rev-list.c | diffblobblamehistory |